Skip to content

Update doc, remove md files. #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2023
Merged

Update doc, remove md files. #1814

merged 2 commits into from
Oct 14, 2023

Conversation

@janiversen
Copy link
Collaborator

@janiversen janiversen commented Oct 11, 2023

No description provided.

@janiversen janiversen force-pushed the rst-md branch 2 times, most recently from 8d1dafb to 6c282da Compare October 12, 2023 12:55
@janiversen janiversen changed the title Convert rst files to md Update doc, remove md files. Oct 12, 2023
@janiversen
Copy link
Collaborator Author

janiversen commented Oct 14, 2023

And just an advice, if you find bugs in the code, then please add another pull request that solves the bug. This pull request should only be typing.

@MAKOMO
Copy link
Contributor

MAKOMO commented Oct 14, 2023

And just an advice, if you find bugs in the code, then please add another pull request that solves the bug. This pull request should only be typing.

Please discard this Pull Request. I am not able to do what you ask me for. Sorry.

@janiversen
Copy link
Collaborator Author

janiversen commented Oct 14, 2023

I think the problem is that you try to solve the whole world in one go, that is difficult, even though I know the code quite good, I would have problems doing that.

Instead of giving up, submit a pull request with the simple changes, basically "| None", easy to review and easy to get merged...then you can focus on the more difficult items in smaller chunks.

But of course its all up to you.

@janiversen janiversen merged commit 94d4217 into dev Oct 14, 2023
@janiversen janiversen deleted the rst-md branch October 14, 2023 18:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janiversen @MAKOMO