Skip to content

Switch from black to ruff-format #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 18, 2023
Merged

Switch from black to ruff-format #1838

merged 5 commits into from
Oct 18, 2023

Conversation

@alexrudd2
Copy link
Collaborator

@alexrudd2 alexrudd2 commented Oct 17, 2023

Note that black has a default line-length: 88 which differed from the 110 which was used (but ignored) for ruff.

janiversen
janiversen approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@alexrudd2
Copy link
Collaborator Author

alexrudd2 commented Oct 18, 2023

OK, if it is too noisy we can revert.

@alexrudd2 alexrudd2 merged commit d445d90 into dev Oct 18, 2023
@alexrudd2 alexrudd2 deleted the ruff branch October 18, 2023 15:04
@alexrudd2 alexrudd2 restored the ruff branch October 18, 2023 15:04
@alexrudd2 alexrudd2 deleted the ruff branch October 18, 2023 15:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janiversen janiversen janiversen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexrudd2 @janiversen