Skip to content

eliminate implicit optional for callback_disconnected #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2023
Merged

eliminate implicit optional for callback_disconnected #1840

merged 1 commit into from
Oct 18, 2023

Conversation

@alexrudd2
Copy link
Collaborator

@alexrudd2 alexrudd2 commented Oct 17, 2023

Eliminates another 4 strict mypy errors.

Thanks @MAKOMO

janiversen
janiversen approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@janiversen janiversen merged commit e0571ca into dev Oct 18, 2023
@janiversen janiversen deleted the callback-disconnected-mypy branch October 18, 2023 05:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janiversen janiversen janiversen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexrudd2 @janiversen