Skip to content

Convert type hints to PEP585 #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2023
Merged

Convert type hints to PEP585 #1846

merged 1 commit into from
Oct 21, 2023

Conversation

@alexrudd2
Copy link
Collaborator

@alexrudd2 alexrudd2 commented Oct 19, 2023 •
edited
Loading

Use from __future__ import annotations for Python3.8 support.

Switch e.g. List[int] to list[int] per PEP585
Replace Union and Optional with |

@alexrudd2 alexrudd2 force-pushed the pep585 branch 2 times, most recently from c4e91e9 to 2416b7d Compare October 19, 2023 20:35
janiversen
janiversen approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexrudd2 alexrudd2 merged commit 8d3e36f into dev Oct 21, 2023
@alexrudd2 alexrudd2 deleted the pep585 branch October 21, 2023 03:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janiversen janiversen janiversen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexrudd2 @janiversen