Rework host/port and listener setup

[alexrudd2]

The refactored code is less nested, so I hope it is easier to understand.

It also solves a mypy error.

[alexrudd2]

See #1865.

If the test that creates host == socket://__pymodbus_nullmodem:7636 is not valid, this can be simplified further.

[janiversen]

You are touching a very delicate part of the code.

Some of your does not seem correct at a first look,but might very well be correct.

I need a bit of time to review this one.

[janiversen]

See #1865.

If the test that creates host == socket://__pymodbus_nullmodem:7636 is not valid, this can be simplified further.

That is a valid specification, the definition is "socket://:" for serial port as sockets.

[alexrudd2]

You are touching a very delicate part of the code.

Some of your does not seem correct at a first look,but might very well be correct.

It will remain a secret, how many test failures I had in my attempts 🤣

[janiversen]

LGTM.

Too fast, have to look at the whole PR:

[alexrudd2]

The reason I tried changing things here to was to avoid this inelegant return of None, None.

if self.comm_params.comm_type == CommType.SERIAL:
        host, port = self.init_setup_serial(host, port)
        if not host and not port:
            return

def init_setup_serial(self, host: str, _port: int) -> tuple[str, int]:
...
return None, None

Perhaps you have a cleaner way.

[janiversen]

The reason I tried changing things here to was to avoid this inelegant return of None, None.

if self.comm_params.comm_type == CommType.SERIAL:
        host, port = self.init_setup_serial(host, port)
        if not host and not port:
            return

def init_setup_serial(self, host: str, _port: int) -> tuple[str, int]:
...
return None, None

Perhaps you have a cleaner way.

Your last change looks ok....but you still have the change with strip and split, which I overlooked when I first approved the PR.

[janiversen]

LGTM, thanks.