Eliminiate implicit optional in reconnect_delay* #1874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janiversen
requested changes
Oct 31, 2023
| comm_type: CommType | None = None | ||
| reconnect_delay: float | None = None | ||
| reconnect_delay_max: float | None = None | ||
| reconnect_delay_max: float = 0.0 |
Collaborator
There was a problem hiding this comment.
Actually there is a hidden problem here, "reconnect_delay_max" is defined a milliseconds and is an integer.
It seems asyncio.py does still use seconds, so I have to look at code before I approve this one.
Collaborator
|
your PR´s are starting to get very small. |
janiversen
approved these changes
Oct 31, 2023
Collaborator
janiversen
left a comment
janiversen
left a comment
There was a problem hiding this comment.
LGTM (reconnect_delay is consistent float).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1856 (comment) and #1856 (comment)