Revert "Make client type annotations compatible with async client usage (#1842)" #1976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janiversen
approved these changes
Feb 7, 2024
Collaborator
janiversen
left a comment
janiversen
left a comment
There was a problem hiding this comment.
OK for me, you can merge if you like
But please consider if this is really the way you want to go, what we have is what is actually being returned.
Collaborator
Author
Both signatures (with or without |
Collaborator
Author
Collaborator
|
As I wrote in the approval, if you feel it´s correct, then just merge it...and lets move on. |
Collaborator
Author
|
Closing in favor of #1980 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 01ad131 (with 2 resolved conflicts)
See discussion in #1842 and issue #1973.
This gets us no close to full type hinting, but does at least fix a bit of breakage :)