solve more mypy issues with datastore #2010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrudd2
force-pushed
the
datastore-types
branch
from
a923d00 to
6a440ca
Compare
Collaborator
|
Now I see where you saw the problems....can you try to remove the ignore, and see if you get a problem with python 3.11 - 3.12...thanks in advance. |
Collaborator
|
I just checked your CI run, it looks a lot as if your dev is not updated (I changed CI a couple of days ago). |
janiversen
approved these changes
Feb 13, 2024
Collaborator
janiversen
left a comment
janiversen
left a comment
There was a problem hiding this comment.
The changes are OK. I like the idea of a TextCell.
Collaborator
|
Just to be sure, I have cleaned out all cache, and CI are running on dev as I write this....if CI turns green, I think the problem is somewhere else...agree ? |
Collaborator
|
dev is green after a new CI run, so I think the problem with "ignore" is an not updated dev branch ? |
Collaborator
Author
|
I think there was a cache problem. Some of the CI runners failed to even have Python installed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves another 15 (counting with
--check-untyped-defs)