Reorganize datastore inheritance #2055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janiversen
approved these changes
Feb 24, 2024
Collaborator
janiversen
left a comment
janiversen
left a comment
There was a problem hiding this comment.
LGTM, thanks.
However it scares me a bit, that no tests were affected .... we really need a lot more testing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves 8 more
mypyerrors, including a real problem inModbusSparseDataBlock.The method
default()(inherited fromModbusBaseDataBlock) does not make any sense for a sparse datastore, whereself.valuesis a dictionary. If called, it will break the implementation.==> Move it to
ModbusSequentialDataBlock.Also,
reset()is defined inModbusBaseDataBlockbut overridden byModbusSparseDataBlock.==> Move it also to
ModbusSequentialDataBlock.