Skip to content

Fix field encoding of Read File Record Response #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix field encoding of Read File Record Response #2075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pymodbus/file_message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def encode(self):
total = sum(record.response_length + 1 for record in self.records)
packet = struct.pack("B", total)
for record in self.records:
packet += struct.pack(">BB", 0x06, record.record_length)
packet += struct.pack(">BB", record.record_length, 0x06)
packet += record.record_data
return packet

Expand Down
4 changes: 2 additions & 2 deletions test/test_file_message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,10 @@ def test_read_file_record_request_execute(self):

def test_read_file_record_response_encode(self):
"""Test basic bit message encoding/decoding."""
records = [FileRecord(record_data=b"\x00\x01\x02\x03")]
records = [FileRecord(record_data=b"\x00\x01\x02\x03\x04\x05")]
handle = ReadFileRecordResponse(records)
result = handle.encode()
assert result == b"\x06\x06\x02\x00\x01\x02\x03"
assert result == b"\x08\x03\x06\x00\x01\x02\x03\x04\x05"

def test_read_file_record_response_decode(self):
"""Test basic bit message encoding/decoding."""
Expand Down