Improve simulator type hints #2084
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves another 3
mypyerrors.config_typesbelow seemed like a good candidate for using aTypedDict(~equivalent to astruct)
pymodbus/pymodbus/datastore/simulator.py
Lines 110 to 117 in 214c7ed
However, I ran into issues:
(1)
mypydoesn't support using variables asTypedDictkeys: python/mypy#7178. This unfortunate deficiency meansTypedDictis not suitable here untilmypyimproves.(2) Using
typeas a key is messy, since it's a "soft keyword". Maybe it would be better to usekind? This should have a benefit beyondmypy.