Move twisted requirement to extra #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@jackjweinstein Please raise the PR against the |
jackjweinstein
force-pushed
the
user/jweinstein/remove_default_twisted_install
branch
from
bef5777 to
a732b83
Compare
Currently some of the asynchronous dependencies (pyasn1, pycrypto) are listed under a 'twisted' extra, but twisted is not. This commit moves twisted to the 'twisted' extra, so that `pip install pymodbus['twisted'] installs twisted and all async dependencies, and `pip install pymodbus` installs only pyserial.
jackjweinstein
force-pushed
the
user/jweinstein/remove_default_twisted_install
branch
from
a732b83 to
d9c5b71
Compare
Contributor
Author
|
@dhoomakethu sure thing, thanks! |
dhoomakethu
pushed a commit
that referenced
this pull request
Oct 26, 2017
Currently some of the asynchronous dependencies (pyasn1, pycrypto) are listed under a 'twisted' extra, but twisted is not. This commit moves twisted to the 'twisted' extra, so that `pip install pymodbus['twisted'] installs twisted and all async dependencies, and `pip install pymodbus` installs only pyserial.
dhoomakethu
pushed a commit
that referenced
this pull request
Oct 26, 2017
Currently some of the asynchronous dependencies (pyasn1, pycrypto) are listed under a 'twisted' extra, but twisted is not. This commit moves twisted to the 'twisted' extra, so that `pip install pymodbus['twisted'] installs twisted and all async dependencies, and `pip install pymodbus` installs only pyserial.
wexi
pushed a commit
to wexi/pymodbus
that referenced
this pull request
Dec 1, 2017
Currently some of the asynchronous dependencies (pyasn1, pycrypto) are listed under a 'twisted' extra, but twisted is not. This commit moves twisted to the 'twisted' extra, so that `pip install pymodbus['twisted'] installs twisted and all async dependencies, and `pip install pymodbus` installs only pyserial.
dhoomakethu
pushed a commit
that referenced
this pull request
Dec 21, 2017
Currently some of the asynchronous dependencies (pyasn1, pycrypto) are listed under a 'twisted' extra, but twisted is not. This commit moves twisted to the 'twisted' extra, so that `pip install pymodbus['twisted'] installs twisted and all async dependencies, and `pip install pymodbus` installs only pyserial.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some of the asynchronous dependencies (pyasn1, pycrypto) are
listed under a 'twisted' extra, but twisted is not. This commit moves
twisted to the 'twisted' extra, so that
pip install pymodbus['twisted'] installs twisted and all async dependencies, andpip install pymodbus`installs only pyserial.