#84: Stop Asynchronous Server #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling this helper function will kill the main thread
Contributor
Author
|
@dhoomakethu , changed the base to |
dhoomakethu
reviewed
Nov 24, 2017
pymodbus/server/async.py
Outdated
| reactor.stop() | ||
| else: | ||
| reactor.callFromThread(reactor.stop) | ||
| _logger.debug("Stopping main thread") |
Contributor
There was a problem hiding this comment.
@rahulraghu94 This log message will be displayed irrespective of whether the current thread is main or child.
Contributor
Author
There was a problem hiding this comment.
Isn't that expected behaviour?
Contributor
Author
There was a problem hiding this comment.
Oh, sorry. I'm on some meds 📦
Fixing...
pymodbus/server/async.py
Outdated
| reactor.run() | ||
|
|
||
|
|
||
| def _stop_server(is_mainthread=True): |
Contributor
There was a problem hiding this comment.
THe param is_mainthread=True is not being used, remove it if unnecessary
wexi
pushed a commit
to wexi/pymodbus
that referenced
this pull request
Dec 1, 2017
* New helper function to help stop Asynchronous server are being added. Calling this helper function will kill the main thread * pymodbus-dev#84: Removing redundant parameters to method _is_main_thread * pymodbus-dev#84: Fixed loggers * pymodbus-dev#84: Retaining one generic StopServer command that will cater to both TCP and Seriel Server * pymodbus-dev#84 Add docuementation to StopServer helper function
dhoomakethu
pushed a commit
that referenced
this pull request
Dec 21, 2017
* New helper function to help stop Asynchronous server are being added. Calling this helper function will kill the main thread * #84: Removing redundant parameters to method _is_main_thread * #84: Fixed loggers * #84: Retaining one generic StopServer command that will cater to both TCP and Seriel Server * #84 Add docuementation to StopServer helper function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New helper function to help stop Asynchronous server are being added.
Calling this helper function will kill the main thread