Change slave to device_id and slave= to device_id=. #2600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a breaking change. I think the latest release should be |
Collaborator
Author
|
Did you read the README, pymodbus does minor API. changes in x.y releases. It is clearly documented what releases can contain ! you might like to have another way of doing it, but we have quite a lot of reasons for not doing semver. v3.10 contains changes which you can solve with a simple edit. v4.0.0 will require a rewrite of parts of your program. |
|
Oh, I am sorry that I have overlooked the README. I mistakenly thought it was semantic versioning. |
Closed
svasek
added a commit
to svasek/homeassistant-vistapool-modbus
that referenced
this pull request
Sep 4, 2025
* Fixed compatibility with pymodbus versions 3.9.x and 3.10+ * Introduced `modbus_acall` and `modbus_scall` for async and sync methods. * Added `address_kwargs` to handle device_id and slave addressing. * Created tests for the new compatibility functions to ensure correctness. Related changes: * pymodbus-dev/pymodbus#2600 * https://github.com/pymodbus-dev/pymodbus/blob/dev/API_changes.rst#api-changes-3100 * home-assistant/core#150129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.