#82 error response api #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 8, 2018 15:31
response codes
Eg:
response = client.write_registers(...)
assert(response.isError() == False)
Contributor
Author
|
@dhoomakethu , all tests using the error API |
dhoomakethu
reviewed
Jan 13, 2018
| count, | ||
| self.unit_id) | ||
| return result.function_code < 0x80 | ||
| return result.isError() |
Contributor
There was a problem hiding this comment.
This should be return not result.isError()
dhoomakethu
reviewed
Jan 13, 2018
examples/functional/base_runner.py
Outdated
| rq = self.client.write_coil(1, True) | ||
| rr = self.client.read_coils(1,1) | ||
| self.__validate(rq, lambda r: r.function_code < 0x80) | ||
| self.__validate(rq, lambda r: r.isError()) |
Contributor
There was a problem hiding this comment.
The check should be for not isError()
dhoomakethu
reviewed
Jan 13, 2018
examples/functional/base_runner.py
Outdated
| rq = self.client.write_coils(1, [True]*8) | ||
| rr = self.client.read_coils(1,8) | ||
| self.__validate(rq, lambda r: r.function_code < 0x80) | ||
| self.__validate(rq, lambda r: r.isError()) |
examples/functional/base_runner.py
Outdated
| rq = self.client.write_coils(1, [False]*8) | ||
| rr = self.client.read_discrete_inputs(1,8) | ||
| self.__validate(rq, lambda r: r.function_code < 0x80) | ||
| self.__validate(rq, lambda r: r.isError()) |
examples/functional/base_runner.py
Outdated
| rq = self.client.write_register(1, 10) | ||
| rr = self.client.read_holding_registers(1,1) | ||
| self.__validate(rq, lambda r: r.function_code < 0x80) | ||
| self.__validate(rq, lambda r: r.isError()) |
pymodbus/datastore/remote.py
Outdated
| _logger.debug("validate[%d] %d:%d" % (fx, address, count)) | ||
| result = self.__get_callbacks[self.decode(fx)](address, count) | ||
| return result.function_code < 0x80 | ||
| return True if result.isError() is False else False |
Contributor
There was a problem hiding this comment.
simplify return not result.isError()
Contributor
Author
|
@dhoomakethu , this is ready now. |
dhoomakethu
force-pushed
the
#82-error-response-api
branch
from
e4abb1a to
bbf6fed
Compare
dhoomakethu
approved these changes
Apr 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the Error Response API in place of manually checking for error codes in examples