Solve issue #721 (selector not valid) #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
dhoomakethu
approved these changes
Mar 25, 2022
Collaborator
Author
|
That does not look like something I caused. |
Collaborator
Nope...seems to be an common error in the setup for that version. I will kick it again. |
Collaborator
|
Hmm... issue still present... @dhoomakethu would you merge it anyway, since the setup for macOS PyPy 3.6 seems to be faulty? Or do you have a clue perhaps what's happening? |
Collaborator
Author
|
Would be nice to get this in the codebase. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client/sync.py/_recv contains a select call, which causes problems if the server aborts, without closing the socket properly.
The loop means that the socket can go "invalid" while waiting for data.
This is tested with a software server, that does assert, after having read a couple of times. This is however a kind of timing issue, because the client needs to be in the _recv loop.
fixes #721