Skip to content

Conversation

@dhoomakethu
Copy link
Contributor

  • Fix read the docs building with python3.5
  • Fix make file referencing wrong requirements file

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dhoomakethu dhoomakethu merged commit 627a58a into dev May 22, 2022
@janiversen
Copy link
Collaborator

Sorry this was my fault, I was no5 aware of the . file.

The Makefile either needs to go away, or be repaired….because all the new tools pylint etc, are to be run with “tox -e ”.

Do you use the makefile? today it is not very common in python projects.

@dhoomakethu
Copy link
Contributor Author

dhoomakethu commented May 22, 2022

No prob, can you check if these generated docs for dev branch is good enough ? https://pymodbus.readthedocs.io/en/dev/.
The makefile was being used in our earlier pipeline I believe. I am just used to running make clean && make test .

@janiversen
Copy link
Collaborator

I miss dev4 in CHANGELOGS.

Apart from the docs look ok, but now I can see that I need the pylint check for :param: in order to secure there are match.

@janiversen janiversen deleted the fix-readthe-docs branch June 2, 2022 20:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants