fix: rename gp242 identifier to gp311_242
#2411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @timfel |
mayeut
added
the
CI: GraalPy
mayeut
commented
May 25, 2025
| @@ -147,7 +147,11 @@ def update_version(self, identifier: str, spec: Specifier) -> AnyConfig: | |||
| msg = f"{identifier} not supported yet on GraalPy" | |||
| raise RuntimeError(msg) | |||
|
|
|||
| gpspec_str = identifier.split("-")[0].split("_")[1] | |||
| gpspec = Specifier("==24.2.*") if gpspec_str == "242" else Specifier(f"=={gpspec_str}.*") | |||
There was a problem hiding this comment.
this is likely to need an update once a new GraalPy version is released
|
Nice catch. This solution makes sense to me. |
|
Looks good to me as well. I took a note to update the update_pythons.py script when we move to 25 |
joerick
reviewed
May 26, 2025
There was a problem hiding this comment.
Just missing the update to the table at https://cibuildwheel.pypa.io/en/latest/options/#build-skip
(i added the row in a parallel PR)
|
Yes, I noticed that too. Should we merge this and then update in the parallel PR? |
|
Oh, I think I see what you mean, okay, I can update it. |
fixes pypa#2410 This normalises identifiers to always start with `{impl}{pyver}`. It's one way of fixing pypa#2410 The rationale behind this solution is while there's only one python version supported by GraalPy for a given version, if PyPy starts to ship a new ABI, we'll probably end-up using `pp311_{ABI_VERSION}` and identifiers will be consistent in between PyPy & GraalPy even if a bit more verbose than needed for GraalPy.
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2410
This normalises identifiers to always start with
{impl}{pyver}. It's one way of fixing #2410The rationale behind this solution is while there's only one python version supported by GraalPy for a given version, if PyPy starts to ship a new ABI, we'll probably end-up using
pp311_{ABI_VERSION}and identifiers will be consistent in between PyPy & GraalPy even if a bit more verbose than needed for GraalPy.