Skip to content

feat: Python 3.14rc1 build by default #2507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 24, 2025
Merged

feat: Python 3.14rc1 build by default #2507

merged 4 commits into from
Jul 24, 2025

Conversation

cibuildwheel-bot[bot]
Copy link
Contributor

Update the versions of our dependencies.

PR generated by "Update dependencies" workflow.

@cibuildwheel-bot cibuildwheel-bot bot added CI: GraalPy Run the integration test suite with GraalPy included CI: PyPy Run the integration test suite with PyPy included dependencies Pull requests that update a dependency file labels Jul 23, 2025
@henryiii henryiii changed the title [Bot] Update dependencies feat: Python 3.14rc1 build by default Jul 23, 2025
@henryiii henryiii requested a review from Copilot July 23, 2025 20:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR promotes Python 3.14 from prerelease to stable status by default, updating from beta 4 (b4) to release candidate 1 (rc1). The changes include adding cp314 and cp314t to the default build identifiers, updating test expectations, and refreshing Docker image versions.

Key changes:

  • Add cp314 and cp314t to DEFAULT_IDS for standard build inclusion
  • Update Python 3.14 version from b4 to rc1 across platform configurations
  • Update selector logic to treat cp315 as the new prerelease version

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
unit_test/option_prepare_test.py Adds cp314 and cp314t to default build IDs and updates test expectations
unit_test/linux_build_steps_test.py Updates test assertions for additional cp314 build configurations
unit_test/build_selector_test.py Adds test cases for cp314 platform selection
test/utils.py Moves cp314 variants from prerelease to default build tags
pyproject.toml Adds pylint configuration for max positional arguments
cibuildwheel/selector.py Updates prerelease filter from cp314 to cp315
cibuildwheel/resources/pinned_docker_images.cfg Updates Docker image versions from 2025.07.20-2 to 2025.07.23-1
cibuildwheel/resources/build-platforms.toml Updates Python 3.14 URLs from b4 to rc1
README.md Removes prerelease notation from Python 3.14 documentation

Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Not sure what's up with that CI run... but doesn't look like a test failure to me, maybe a platform failure?

@joerick
Copy link
Contributor

joerick commented Jul 23, 2025

I ran the test suite locally on Mac and it was fine. Have restarted it here but it's fine to merge IMO.

@henryiii
Copy link
Contributor

I think it's fine to merge too, the failing part wasn't related to RC1 anyway.

Comment on lines 88 to 89
if EnableGroup.CPythonFreeThreading not in self.enable and fnmatch(build_id, "cp313t-*"):
return False
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there was any discussion about it already. Should cp314t really be build by default? I'm not involved enough in the free threading ecosystem to know the current state of things. At least for mypy, I'd probably need to disable the builds manually to get the build pipeline to pass if the PR is merged as is.

The enable = ["cpython-freethreading"] option feels safer at least for the moment.

Copy link
Contributor

@henryiii henryiii Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting with CPython 3.14 beta 3, free-threading is no longer experimental. That means every package should strive to produce free-threading wheels, and they should opt out rather than opt in, unlike 3.13. We only had the enable while it was experimental ("This will enable building these wheels while they are experimental." was the exact quote in our docs). We turned this off in a previous PR #2503, and that’s where you can see the text about this only being true while experimental. https://peps.python.org/pep-0779/

I think it's fine if you have to turn it off, you are explicitly stating you don't fully support all of 3.14. Most binding tools (pybind11, nanobind, cython, SWIG, PyO3, see https://py-free-threading.github.io/tracking/) have supported free threading for quite a while. MyPyC is one of the largest ones that doesn't, I think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I did see that it's no longer considered experimental. Though I'd say that mainly applies for cpython itself. Not sure how far along the ecosystem itself is / how challenging it is to get the free threading builds to pass.

I'd suspect this will probably take another year or two, at least.

Copy link
Contributor

@henryiii henryiii Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but hopefully this will push people to start supporting it if they aren't already. The next stage will require most packages to support it, and I think the point of declaring it no longer experimental upstream is to signal that you can't just ignore it anymore downstream, which is also what we are also doing by requiring it to be explicitly skipped. Plus we explicitly said the enable was only going to be valid while it was experimental upstream. :)

We used to require PyPy be explicitly skipped, and we still require musllinux to be explicitly skipped, so we have a bit of a history of requiring skips. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting free threading working hasn't been that bad, though mostly people like @ngoldbaum and @colesbury have done a hero's share of the work, so maybe I shouldn't claim anything about how hard it was. ;) I'd guess it's not that bad for MyPyC, especially if you just supported 3.14t+, which is a little easier.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd love to chat about adding support for free-threading in MyPyC.

I did the lion's share of the work for NumPy and PyO3 and our team has been involved in updating Cython, CFFI, SWIG and many other packages across the ecosystem. There's also the guide we're maintaining at https://py-free-threading.github.io.

All that to say we've accumulated a fair bit of know-how for this and we'd very much like to help out with MyPyC. In almost all cases we've looked at so far the issues have been more tractable than people initially feared.

Copy link

@cdce8p cdce8p Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I suspected at least for mypy there were quite a few build errors. This is just from a test run: https://github.com/cdce8p/mypy_mypyc-wheels/actions/runs/16496179019/job/46642337801#step:4:4390.

We'd love to chat about adding support for free-threading in MyPyC.

This isn't my area of expertise per se. Feel free to engage on the issue tracker though. I believe this is the relevant issue for it: mypyc/mypyc#1038.

Copy link

@cdce8p cdce8p Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add one more datapoint only because I saw it just now: The dependabot update compatibility for cibuildwheel is at 33% currently. Obviously it's difficult to tell if that's because of 314, free threading or a combination of both.

Anyway the release notes make it quite obvious how to disable it so it isn't really an issue.

@henryiii henryiii merged commit 10c727e into main Jul 24, 2025
28 checks passed
@henryiii henryiii deleted the update-dependencies-pr branch July 24, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: GraalPy Run the integration test suite with GraalPy included CI: PyPy Run the integration test suite with PyPy included dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants