BUG: hotfix report defects in logs and HTML summaries #2512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
hotfix-summaries
branch
from
3ee69aa to
e25855f
Compare
|
looks like I should have run tests locally after all... sorry for the time this wasted. Let's try again, this time including test changes. |
neutrinoceros
force-pushed
the
hotfix-summaries
branch
from
2c26c82 to
4221741
Compare
henryiii
approved these changes
Jul 24, 2025
|
Unrelated to this PR, but @mhsmith all PRs are getting this warning: Pylint is detecting a circular import that Python is able to handle at runtime. Maybe there's a way to remove the circular pattern, or we can just silence the warning. |
|
In this context the circular import is perfectly safe, so I've silenced it in #2515. |
joerick
reviewed
Jul 25, 2025
| @@ -242,11 +242,11 @@ def print_summary(self, *, options: "Options") -> Generator[None, None, None]: | |||
| github_summary = self._github_step_summary(duration=duration, options=options) | |||
| Path(summary_path).write_text(filter_ansi_codes(github_summary), encoding="utf-8") | |||
|
|
|||
| n = len(self.summary) | |||
| s = "s" if n > 1 else "" | |||
| n_wheels = len([info for info in self.summary if not info.filename]) | |||
There was a problem hiding this comment.
@neutrinoceros The not here is looking wrong to me!
There was a problem hiding this comment.
oh my, definitely 🤦🏻♂️ I'll fix this in a minute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2511
disclaimer: I have not attempted to run tests locally yet (I have very limited battery at the moment), but I did run typechecking via
pre-commit, which correctly caught a mistake in my initial iteration, so I'm reasonably confident in this patch.