PEP8 WIP (#227) #228
Open
PEP8 WIP (#227) #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
PEP 8 is a PEP for contributing code to the standard library: https://peps.python.org/pep-0008/#introduction
It is not a packaging PEP and does not need to be adhered by any project other than the standard library (and PEP 8 gives many reasons why you might not adhere to it's styling rules even in the standard library). So it doesn't make sense to advise this for a sample project. |
| # due to using nox and pytest | ||
| .nox | ||
| .cache | ||
| .pre-commit-config.yaml |
There was a problem hiding this comment.
Also, this is wrong, if a project provides a .pre-commit-config.yaml it should be checked in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #227