Fix python_version metadata extraction for bdist_egg distributions #1192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This looks fine to me behaviorally, but is there a reason we're supporting |
dnicolodi
force-pushed
the
egg-pyversion
branch
from
a594f54 to
b7d5b68
Compare
Contributor
Author
|
I think the fix is much less invasive than removing support for eggs. However, if there is consensus that removing support for eggs is the best way forward, I can do that instead. If support for eggs is removed, support for wininsts should probably be removed too. |
Contributor
Author
|
bdist_egg support has been removed in #1195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1190.