fix cache invalidation for PythonInfo #2925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cache for PythonInfo is now invalidated if the PythonInfo class changes. I achieved this by hashing the py_info.py file and storing the hash in the cache. When loading from the cache, the hash is recomputed and compared with the stored hash. If they don't match, the cache is invalidated. Fixes pypa#2647 Signed-off-by: Emre Şafak <[email protected]>
gaborbernat
previously approved these changes
Aug 1, 2025
Seems this is a valid error, you'll need to fix it. |
* Add `encoding="utf-8"` to `subprocess.run` calls in `tests/unit/discovery/test_discovery.py` for consistent text handling. * Update assertion in `tests/unit/discovery/py_info/test_py_info.py` to handle potential multiple calls on Homebrew installations. * Ensure consistent text encoding across subprocess executions in discovery tests. Signed-off-by: Emre Şafak <[email protected]>
Signed-off-by: Emre Şafak <[email protected]>
|
That linter rule is dumb. It will be happier if I completely remove the comment leaving everybody in the dark. Should I remove it? |
Signed-off-by: Emre Şafak <[email protected]>
Signed-off-by: Emre Şafak <[email protected]>
|
@esafak you need to fix the pre commit check 😊 |
Signed-off-by: Emre Şafak <[email protected]>
gaborbernat
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache for PythonInfo is now invalidated if the PythonInfo class changes. I achieved this by hashing the py_info.py file and storing the hash in the cache. When loading from the cache, the hash is recomputed and compared with the stored hash. If they don't match, the cache is invalidated.
Fixes #2467
tox -e fix)docs/changelogfolder