feat: add type hints #130
Merged
feat: add type hints #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The camelCase functions have been marked as deprecated. Replace with equivalent snake_case functions. Move `set_name()` assignments to their parent `Word` when possible, to address a type error since `set_results_name()` emits a `ParserElement`, not a `Word`. Signed-off-by: Mike Fiedler <[email protected]>
- Add type hint to the one public interface for user agent parsing. - Add testing step to CI - Include type marker in package - Set classifier metadata Signed-off-by: Mike Fiedler <[email protected]>
di
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linehaul/events/parser.pyResolves #123
Signed-off-by: Mike Fiedler [email protected]