Add test for logged in menu

[nlhkabu]

We have a test for the menu when the user is logged out here:

https://github.com/pypa/warehouse/blob/1cf194fc4591efcfa19ed518ecdaa21e0865afdf/tests/functional/test_basic.py#L41

Now that we have the logged in menu, we should test the opposite, e.g. test_indicator_shows_logged_in

[gtback]

I'm happy to work on this. I'm not sure how to create a user or log in to the site via PhantomJS/Selenium (I'm sure I can figure it out, but wanted to make sure I'm not missing anything).

I also noticed that the URLs aren't all directly in the user-indicator div, but in a separate dropdown, so the test will have to take that into account. Also, it appears the "Logout" functionality uses a form. Does it make sense to also check that there's a form present, that has a hidden csrf_token field, to make sure if that ever gets removed there's a failing test?

[di]

The original test test_indicator_shows_not_logged_in no longer exists since #2481.

Perhaps this issue should be modified to something like "add some frontend tests"? Not sure that should be part of the milestone, though.

[brainwane]

@gtback In today's Warehouse developers' meeting we decided to pare down our near-future milestones on our development roadmap so they really only contain the essential bugfixes and features we need to launch, replace legacy PyPI, and shut down the old site. So I'm moving this issue into a milestone further in the future.

But you can still work on this issue if you'd like; I'd love for Warehouse to have more tests, including frontend tests! As always, if you have questions along the way as you work on this, please feel free to ask them here, in #pypa-dev on Freenode, or the pypa-dev mailing list.

I'm very sorry for the wait, and thank you!

[takluyver]

Heads up that phantomjs development has been suspended. Both Firefox and Chrome now have headless modes that can be driven from Selenium for testing, though.