Switch to cpythons file object implementation #1090
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to the cpython file object implementation and printing code.
This makes us pass the following cpython tests:
This also make use now call much more often into
tp_printwhich we do not implement for many types. I think in the future we should add them because this functions can directly write to a file descriptor instead of having to always write into a buffer. I had to add it for the dict type because the default dict implementation requires it.In addition fixes a pyopenssl integration test error: