Skip to content

Conversation

@corona10
Copy link

Accoring to #1100 I change some files.

@undingen
Copy link
Contributor

oh wow that fast fast, thanks for working on this :-)
I think we don't need the declarations inside the errors.cpp file they should already be declared inside the pyerrors.h header.
And I noticed that there is a small difference inside the PyErr_NormalizeException function please copy the change over to the new errors.c file (but in a separate commit so that we have the original version as the first commit and the changes to the file in another one)
Thanks!

@corona10
Copy link
Author

@undingen Thanks. I fix them as you reviewed.

undingen added a commit that referenced this pull request Feb 15, 2016
Directly use cpythons errors.c file
@undingen undingen merged commit 2e2456b into pyston:master Feb 15, 2016
@undingen
Copy link
Contributor

thanks for the patch!

@corona10 corona10 deleted the error branch February 15, 2016 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants