Misc refcounting leaks encountered while fixing the generator abandonment tests #1140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| auto&& p = set->s.insert(data[i]); | ||
| if (!p.second /* already exists */) { | ||
| Py_DECREF(p.first->value); | ||
| *p.first = data[i]; |
There was a problem hiding this comment.
I think this should use the original value and decref the duplicate one: set([1, 1L]) is 1 for CPython and 1L for us.
There was a problem hiding this comment.
This matches the behavior for dict keys, but is different from dict values -- {1:1, 1L:1L} is {1: 1L}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes leaks in
tp_setattrfromsetattr()I could not enable the tests yet because the need the generator abandonment fix but this fix is not ready yet but I want to land this fixes now so we don't do duplicate work.