Optimize stattimers #582
Merged
Optimize stattimers #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This roughly halves stattimer overhead, from +80% to +40% (on a very small benchmark; more complex benchmarks probably have lower overhead)
I would have expected this to help a bunch but it seems to actually hurt
Main change is separating the representation of the timer stack (StatTimer) from the manipulation of it (ScopedStatTimer). This makes it easier to keep the different use cases (top level timers vs non-top-level) separate without having the individual functions check whether they think they are a top-level timer or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to remove a few of the hottest ones (gc_alloc, isSubclass), but with that it cuts the StatTimer overhead from +80% (on a very simple benchmark) to about +10%.