Notion of redundant visits to slowly move towards scanning everything #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes a little bit more sense. |
|
For visiting objects on the stack, I have another variant like this: The advantage is that it can be used for any kind of stack-bound lifetime, including pointers in unique_ptrs. So we would use this version also, for the rewriter. However, the We could keep both, or just the more general one. What you think? |
|
I'm +1 on the variant you posted in your comment -- it seems similar to what other VMs use for their precise stack scanning and seems like it could be a step towards that for us. I think the extra-object issue can be resolved by making the handle the only object; ie for the rewrite case do something like gc::RootingHandler<std::unique_ptr<Rewriter>> rewriter(createRewriter());
rewriter->commit();Well, it might be tricky specifically in the case of unique_ptr. |
|
I'm a bit confused about the last commit in this PR -- were we not already scanning interpreter references? |
|
I was concerned about |
rudi-c
force-pushed
the
redundantvisit
branch
from
b2e16eb to
3b888a6
Compare
|
Ok I've removed the commit that deals with ASTInterpreter. As far as the calling gc handler on stack objects is concerned, I'll put that in another commit when I scan the rewriter. |
rudi-c
force-pushed
the
redundantvisit
branch
from
3b888a6 to
1d63c9d
Compare
For marking collectors, the redudant visits no-op to avoid the performance hit.
rudi-c
force-pushed
the
redundantvisit
branch
3 times, most recently
from
218c35e to
d80c374
Compare
rudi-c
force-pushed
the
redundantvisit
branch
from
d80c374 to
592f854
Compare
kmod
added a commit
that referenced
this pull request
Sep 1, 2015
Notion of redundant visits to slowly move towards scanning everything
|
cool :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all references in the program are being scanned, but we get away with it for now. Until we having a moving collector, don't actually scan those references, but make note that they are there.
I have no idea how the extra code I added ended up making things faster, it's probably a fluke, but at least it's not slower.