Lower initial dict/set size from 64->8 #886
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm's DenseMap/DenseSet have a hardcoded minimum size of 64 buckets, which I think ends up wasting a lot of memory for us. They also take longer to iterate over (more empty buckets to skip), which is probably not as big a deal in the macrobenchmarks but shows up in some microbenchmarks.
So, fork their implementation and lower the minimum to 8 (parameterizable now). Surprisingly effective: