Skip to content

Conversation

@undingen
Copy link
Contributor

Please take a look at the the individual commits to figure out whats changed.
The switch from 4byte to a 2byte unicode type changed a lot of the unicode functions names so it maybe a good idea to regenerate the section ordering file but I was not sure with which perf sample I have to run it.

                                   upstream/master:        origin/pyxl2:
           django_template3.py             2.2s (4)             2.1s (2)  -1.8%
                 pyxl_bench.py             1.8s (4)             1.8s (2)  +1.3%
     sqlalchemy_imperative2.py             2.3s (4)             2.3s (2)  +0.7%
                pyxl_bench2.py             1.3s (4)             1.1s (2)  -19.5%
       django_template3_10x.py            14.1s (4)            13.6s (2)  -3.7%
             pyxl_bench_10x.py            13.9s (4)            14.2s (2)  +1.6%
 sqlalchemy_imperative2_10x.py            17.6s (4)            17.9s (2)  +1.4%
            pyxl_bench2_10x.py            11.8s (4)             9.1s (2)  -22.6%
                       geomean                 5.1s                 4.8s  -5.8%

@undingen undingen force-pushed the pyxl2 branch 3 times, most recently from a6c9961 to d2654e5 Compare October 21, 2015 16:08
@kmod
Copy link
Collaborator

kmod commented Oct 21, 2015

Can we split out the unicode change? Just double-checked that Dropbox's build is a wide build, so I'm not sure what kinds of issues would be caused by switching to a narrow build. I wouldn't be surprised if it's fine to make the change (or if it's not) but I think it's a bit more complicated than the rest of the changes in the PR.

fyi you can run make update_section_ordering and it will do everything and update the section ordering file in place :)

@undingen
Copy link
Contributor Author

I removed the unicode change

                                   upstream/master:        origin/pyxl2:
           django_template3.py             2.2s (4)             2.2s (2)  +0.1%
                 pyxl_bench.py             1.8s (4)             1.8s (2)  +0.7%
     sqlalchemy_imperative2.py             2.3s (4)             2.3s (2)  +1.2%
                pyxl_bench2.py             1.3s (4)             1.1s (2)  -14.9%
       django_template3_10x.py            14.2s (4)            14.3s (2)  +0.6%
             pyxl_bench_10x.py            14.3s (4)            13.9s (2)  -3.0%
 sqlalchemy_imperative2_10x.py            17.5s (4)            17.7s (2)  +1.1%
            pyxl_bench2_10x.py            12.2s (4)             9.6s (2)  -21.2%
                       geomean                 5.2s                 4.9s  -4.8%

@undingen undingen force-pushed the pyxl2 branch 2 times, most recently from 33bc76a to 63c97cb Compare October 27, 2015 10:39
@undingen
Copy link
Contributor Author

I now using the much nicer PyArg_ParseSingle: undingen@36ff3d2
and removed the gc untracke memory check: undingen@8245976
Should be ready for merging

kmod added a commit that referenced this pull request Oct 28, 2015
Misc optimizations for pyxl2
@kmod kmod merged commit 045a427 into pyston:master Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants