Skip to content

Conversation

@asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Jan 14, 2022

Type checking is rough, better checks require not released yet pytest 7.0 at least.

Tests are not typed to don't pollute this big enough PR.
They can be typed later.

Fixes #198

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022

Codecov Report

Merging #260 (a94f91e) into master (0a3328f) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   93.13%   93.02%   -0.11%     
==========================================
  Files           3        3              
  Lines         233      258      +25     
  Branches       33       33              
==========================================
+ Hits          217      240      +23     
- Misses         10       12       +2     
  Partials        6        6              
Impacted Files Coverage Δ
plugin.py 92.88% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a3328f...a94f91e. Read the comment docs.

@asvetlov
Copy link
Contributor Author

The PR is green

@asvetlov asvetlov merged commit 308f308 into master Jan 15, 2022
@asvetlov asvetlov deleted the types branch January 15, 2022 12:59
@asvetlov
Copy link
Contributor Author

Merged, if we require the type info -- better to add it fast, other PRs can use typing from the very beginning.

asvetlov added a commit that referenced this pull request Jan 15, 2022
@jeremad
Copy link

jeremad commented Jan 18, 2022

That's great thank you very much. Sorry for the lack of response to your question in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add type annotations

5 participants