Improve error message when using @pytest.fixture twice #11670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While obvious in hindsight, this error message confused me. I thought my fixture function was used in a test function twice, since the wording is ambiguous. Also, the error does not tell me *which* function is the culprit. Finally, this adds a test, which wasn't done in cfd16d0 where this was originally implemented.
The-Compiler
added
the
needs backport
for more information, see https://pre-commit.ci
bluetech
approved these changes
Dec 5, 2023
Member
|
@The-Compiler is this ready to merge or still needs work? |
Member
Author
|
Thanks for the reminder, completely forgot about this! Good to merge I'd say. |
flying-sheep
pushed a commit
to flying-sheep/pytest
that referenced
this pull request
Apr 9, 2024
) * Improve error message when using @pytest.fixture twice While obvious in hindsight, this error message confused me. I thought my fixture function was used in a test function twice, since the wording is ambiguous. Also, the error does not tell me *which* function is the culprit. Finally, this adds a test, which wasn't done in cfd16d0 where this was originally implemented. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While obvious in hindsight, this error message confused me. I thought my fixture function was used in a test function twice, since the wording is ambiguous.
Also, the error does not tell me which function is the culprit.
Finally, this adds a test, which wasn't done in
cfd16d0 where this was originally implemented.