Add new asset classes to price feeds documentation #928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Net Asset Value subclass under Crypto - Change Indices to Index under Crypto - Update Crypto Spot Prices to just Crypto with clarification - Add Futures Prices under US Equities - Add Spot Prices under Commodities - Add Economic Data asset class - Add Event Contracts asset class with note about resolved markets Co-Authored-By: [email protected] <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…TeX parsing issues Co-Authored-By: [email protected] <[email protected]>
- Fix 'ass' to 'as' in Net Asset Value definition - Fix 'predition' to 'prediction' in Event Contracts definition Co-Authored-By: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the asset classes documentation to include new asset types and improve existing classifications based on internal team discussions. The changes add support for Economic Data feeds, Event Contracts (Kalshi), and several new subclasses under existing asset types.
Link to Devin run: https://app.devin.ai/sessions/1898a5d83f2942bf8f27d185f844c461
Requested by: [email protected] ([email protected])
Type of Change
Areas Affected
pages/price-feeds/core/price-feeds/asset-classes.mdx- Asset classes documentation tableChanges Made
Updated Existing Classifications
New Asset Classes
Human Review Checklist
Critical items to verify:
Checklist
pre-commit run --all-filesto check for linting errors (rannpm run lint)Related Issues
Based on internal Slack discussion in #eng-tech-questions thread.
Additional Notes
These changes were requested to properly document existing and upcoming feed types. The Event Contracts asset class is particularly important for Kalshi integration, where the 0/1 price resolution logic needs to be clearly documented for users who will build derivatives based on these feeds.
Screenshots
Local development server rendering:
