-
Notifications
You must be signed in to change notification settings - Fork 33
add function to combine accumulator update #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| return result | ||
|
|
||
|
|
||
| class MerkleUpdate: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this name is based on the Accumulator Wire Format document on Notion
ali-behjati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is very nice! i think there are some duplicate codes that we can remove. I like to review again after you removed them.
ali-behjati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
add function to combine accumulator updates by:
update_dataand check theirvaavaa, combine them into one accumulator update by incrementing the number of updates in the firstupdate_dataand appending the update toupdatesvaa, keep themupdate_dataformat