Skip to content

Update Android test arguments #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

Update Android test arguments #638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions master/custom/factories.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1249,8 +1249,7 @@ def setup(self, **kwargs):
),
Test(
command=[
android_py, "test", "--managed", "maxVersion", "-v", "--",
"--slow-ci", "--single-process", "--no-randomize",
android_py, "test", "--managed", "maxVersion", "-v", "--slow-ci"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need -- separator anymore?

Copy link
Member Author

@mhsmith mhsmith Oct 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right: we added --fast-ci and --slow-ci as options for the outer script, so it knows to add the Python interpreter options:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok, I just wanted to double check.

],
timeout=step_timeout(self.test_timeout),
),
Expand Down