[3.11] Clarify re docs for byte pattern group names (GH-99308) #101001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Per comment I don't believe there should be a backport for this. |
Contributor
Author
|
#99308 (comment) says otherwise |
CAM-Gerlach
reviewed
Jan 14, 2023
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
Thanks @Kentzo . One set of suggestions, otherwise LGTM
hauntsaninja
approved these changes
Jan 17, 2023
Contributor
There was a problem hiding this comment.
Thanks for backporting this!
Looks like it's common enough for past versions of docs to contain "removed" for future versions of Python, so would you mind applying CAM's suggestions?
Edit: Since this has been lying around, I think this is fine to merge as is without the more specific directives; 3.12 isn't finalised and this seems like a short time between deprecation and removal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.