Skip to content

Conversation

@carljm
Copy link
Member

@carljm carljm commented Apr 28, 2023

Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, super minor... but maybe use cls instead of klass for this?

It's a much more common name in our codebase... and I personally like it a lot more. 🙃

@carljm carljm enabled auto-merge (squash) April 28, 2023 18:51
@carljm carljm merged commit ebf97c5 into python:main Apr 28, 2023
@carljm carljm deleted the fixclass branch April 28, 2023 19:21
@tacaswell
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'class' parameter name in headers breaks building C++ extensions

5 participants