gh-90953: Don't use deprecated AST nodes in clinic.py #104322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
I think it is fine to require Python 3.8 for clinic.py. Argument Clinic is for CPython development, and its primary purpose is to generate code for this repo. Third party projects may use it, but must do so completely at their own risk. |
erlend-aasland
approved these changes
May 9, 2023
|
Thanks both! |
carljm
added a commit
to carljm/cpython
that referenced
this pull request
May 10, 2023
* main: pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182) pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364) pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539) pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292) pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202) pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013) pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355) pythongh-103960: Dark mode: invert image brightness (python#103983) pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253) pythongh-101819: Clean up _io windows console io after pythongh-104197 (python#104354) pythongh-101819: Harden _io init (python#104352) pythongh-103247: clear the module cache in a test in test_importlib/extensions/test_loader.py (pythonGH-104226) pythongh-103848: Adds checks to ensure that bracketed hosts found by urlsplit are of IPv6 or IPvFuture format (python#103849) pythongh-74895: adjust tests to work on Solaris (python#104326) pythongh-101819: Refactor _io in preparation for module isolation (python#104334) pythongh-90953: Don't use deprecated AST nodes in clinic.py (python#104322) pythongh-102327: Extend docs for "url" and "headers" parameters to HTTPConnection.request() pythongh-104328: Fix typo in ``typing.Generic`` multiple inheritance error message (python#104335)
ambv
added
needs backport to 3.9
needs backport to 3.10
|
Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2025
…-104322) (cherry picked from commit fe694a6) Co-authored-by: Alex Waygood <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2025
…-104322) (cherry picked from commit fe694a6) Co-authored-by: Alex Waygood <[email protected]>
|
GH-140854 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2025
…-104322) (cherry picked from commit fe694a6) Co-authored-by: Alex Waygood <[email protected]>
|
Sorry, @AlexWaygood, I could not cleanly backport this to |
|
GH-140855 is a backport of this pull request to the 3.10 branch. |
|
GH-140856 is a backport of this pull request to the 3.11 branch. |
ambv
pushed a commit
that referenced
this pull request
Oct 31, 2025
…) (GH-140855) (cherry picked from commit fe694a6) Co-authored-by: Alex Waygood <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Oct 31, 2025
… (GH-140854) (cherry picked from commit fe694a6) Co-authored-by: Alex Waygood <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Oct 31, 2025
…) (GH-140856) (cherry picked from commit fe694a6) Co-authored-by: Alex Waygood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following 376137f, usage of
ast.Numandast.StrcausesDeprecationWarnings to be emitted. This PR updatesclinic.pyto use the newer AST nodes, avoiding deprecation warnings when runningtest_clinic.py.It looks like this script currently takes pains so that it can maintain compatibility with older Python versions. This change means that it won't be possible to run it on Python 3.7 anymore, but Python 3.7 is nearly end-of-life now anyway.