-
-
Couldn't load subscription status.
- Fork 33.3k
gh-102541: Fix Helper.help("mod") for non-existent mod #105934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @corona10 |
|
I am out of OSS for this month. If this PR is urgent, I would like to request reviewing of this PR to other reviewers. |
|
Thanks @Eclips4 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…H-105934) If the output arg to Helper() is a stream rather than the default None, which means 'page to stdout', the ImportError from pydoc.resolve is currently not caught in pydoc.doc. The same error is caught when output is None. --------- (cherry picked from commit 0530f4f) Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
|
GH-106322 is a backport of this pull request to the 3.12 branch. |
…H-105934) If the output arg to Helper() is a stream rather than the default None, which means 'page to stdout', the ImportError from pydoc.resolve is currently not caught in pydoc.doc. The same error is caught when output is None. --------- (cherry picked from commit 0530f4f) Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
|
GH-106323 is a backport of this pull request to the 3.11 branch. |
) (#106323) gh-102541: Fix Helper.help("mod") for non-existent mod (GH-105934) If the output arg to Helper() is a stream rather than the default None, which means 'page to stdout', the ImportError from pydoc.resolve is currently not caught in pydoc.doc. The same error is caught when output is None. --------- (cherry picked from commit 0530f4f) Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
) (#106322) gh-102541: Fix Helper.help("mod") for non-existent mod (GH-105934) If the output arg to Helper() is a stream rather than the default None, which means 'page to stdout', the ImportError from pydoc.resolve is currently not caught in pydoc.doc. The same error is caught when output is None. --------- (cherry picked from commit 0530f4f) Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
If the
outputarg toHelper()is a stream rather than the default None, which means 'page to stdout', the ImportError frompydoc.resolveis currently not caught in `pydoc.doc. The same error is caught when output is None.Traceback:
EDITED by terryjreedy July 1, 2023 to better describe the issue, so I could review the patch,
and show the current result after the merge of the first PR for the issue. Instead of the last line
there were about 15 lines that repeated the Traceback.
helpCLI shows a traceback when import failed #102541