Revert "gh-46376: Return existing pointer when possible in ctypes (#1… #108688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es (python#107131)" This reverts commit 08447b5. Revert also _ctypes.c changes of the PyDict_ContainsString() change, commit 6726626.
Member
Author
|
@ambv @code-of-kpp: Would you be ok to revert the change to fix #107940 regression for now, and reapply the change later once the regression is fine? |
Member
Author
This change is not in the 3.12 branch. This PR should be backported manuallly to the 3.12 branch with |
2 tasks
Member
Author
Thanks :-) |
hugovk
pushed a commit
to hugovk/cpython
that referenced
this pull request
Sep 4, 2023
…es (#1… (python#108688) This reverts commit 08447b5. Revert also _ctypes.c changes of the PyDict_ContainsString() change, commit 6726626.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…07131)"
This reverts commit 08447b5.
Revert also _ctypes.c changes of the PyDict_ContainsString() change, commit 6726626.