gh-125298: Removed misleading os.kill description
#125749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zooba
added
needs backport to 3.12
|
Thanks @rruuaanng for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 8, 2024
…honGH-125749) Windows has not accepted process handles in many releases. (cherry picked from commit 75ffac2) Co-authored-by: RUANG (James Roy) <[email protected]>
|
GH-126587 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 8, 2024
…honGH-125749) Windows has not accepted process handles in many releases. (cherry picked from commit 75ffac2) Co-authored-by: RUANG (James Roy) <[email protected]>
|
GH-126588 is a backport of this pull request to the 3.12 branch. |
zooba
pushed a commit
that referenced
this pull request
Nov 8, 2024
Windows has not accepted process handles in many releases. (cherry picked from commit 75ffac2) Co-authored-by: RUANG (James Roy) <[email protected]>
zooba
pushed a commit
that referenced
this pull request
Nov 8, 2024
Windows has not accepted process handles in many releases. (cherry picked from commit 75ffac2) Co-authored-by: RUANG (James Roy) <[email protected]>
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
…honGH-125749) Windows has not accepted process handles in many releases.
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…honGH-125749) Windows has not accepted process handles in many releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @zooba
📚 Documentation preview 📚: https://cpython-previews--125749.org.readthedocs.build/
In the document,
The Windows version of kill() additionally takes process handles to be killed.actually refers to TerminateProcess, but this is not what users need to know. Users only need to know that the signature of kill is os.kill(pid, sig). So I removed this meaningless description.