gh-126008: Improve docstrings for Tkinter cget and configure methods #133303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thods * Explain the behavior of Widget.configure() depending on arguments. * Unify descriptions. * Replace "resource" with "option".
serhiy-storchaka
added
docs
tomasr8
reviewed
May 2, 2025
terryjreedy
previously requested changes
May 3, 2025
|
When you're done making the requested changes, leave the comment: |
bskinn
reviewed
Jun 2, 2025
Co-authored-by: Brian Skinn <[email protected]>
terryjreedy
dismissed
their stale review
We agree that it would be better to have a separate issue/PR to handle option name formatting in docstrings in this entire file.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 12, 2025
…thods (pythonGH-133303) * Explain the behavior of Widget.configure() depending on arguments. * Unify descriptions. * Replace "resource" with "option". (cherry picked from commit 027cacb) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 12, 2025
…thods (pythonGH-133303) * Explain the behavior of Widget.configure() depending on arguments. * Unify descriptions. * Replace "resource" with "option". (cherry picked from commit 027cacb) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-137660 is a backport of this pull request to the 3.14 branch. |
|
GH-137661 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Aug 12, 2025
…ethods (GH-133303) (GH-137661) * Explain the behavior of Widget.configure() depending on arguments. * Unify descriptions. * Replace "resource" with "option". (cherry picked from commit 027cacb) Co-authored-by: Serhiy Storchaka <[email protected]>
|
Thank you for your review, @terryjreedy, @bskinn. |
maurycy
added a commit
to maurycy/cpython
that referenced
this pull request
Aug 12, 2025
* main: pythongh-137288: Update 3.14 magic numbers (pythonGH-137665) pythongh-135228: When @DataClass(slots=True) replaces a dataclass, make the original class collectible (take 2) (pythonGH-137047) pythongh-126008: Improve docstrings for Tkinter cget and configure methods (pythonGH-133303) pythongh-131885: Use positional-only markers for ``max()`` and ``min()`` (python#131868) pythonGH-137426: Remove code deprecation of `importlib.abc.ResourceLoader` (pythonGH-137567) pythongh-125897: Mark range function parameters as positional only (python#125945) pythongh-137400: Fix a crash when disabling profiling across all threads (pythongh-137471) pythongh-115766: Fix IPv4Interface.is_unspecified (pythonGH-137326) pythongh-128813: cleanup C-API docs for PyComplexObject (pythonGH-137579) pythongh-135953: Profile a module or script with sampling profiler (python#136777) Fix documentation of hash in PyHash_FuncDef (python#137595)
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…thods (pythonGH-133303) * Explain the behavior of Widget.configure() depending on arguments. * Unify descriptions. * Replace "resource" with "option".
encukou
pushed a commit
that referenced
this pull request
Oct 7, 2025
…ethods (GH-133303) (GH-137660) * Explain the behavior of Widget.configure() depending on arguments. * Unify descriptions. * Replace "resource" with "option". (cherry picked from commit 027cacb) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.