[3.13] gh-137400: Fix thread-safety issues when profiling all threads (gh-137518) #137733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hreads (pythongh-137518) There were a few thread-safety issues when profiling or tracing all threads via PyEval_SetProfileAllThreads or PyEval_SetTraceAllThreads: * The loop over thread states could crash if a thread exits concurrently (in both the free threading and default build) * The modification of `c_profilefunc` and `c_tracefunc` wasn't thread-safe on the free threading build. (cherry picked from commit a10152f) Co-authored-by: Sam Gross <[email protected]>
This was referenced Aug 13, 2025
|
FYI, the ABI change seems fine to me. |
colesbury
requested review from
encukou,
ericsnowcurrently and
markshannon
as code owners
markshannon
reviewed
Oct 3, 2025
| self.set = not self.set | ||
|
|
||
|
|
||
| @threading_helper.requires_working_threading() |
There was a problem hiding this comment.
Presumably this test should work regardless of the threading model?
So, maybe just run this test unconditionally?
There was a problem hiding this comment.
I think the InstrumentationMultiThreadedMixin subclasses hang on wasi where there are just no-op pthread stubs.
encukou
approved these changes
Oct 8, 2025
I generally agree, but one of the reasons I decided to backport this is that I think it will make the free-threaded CI more stable as well as fixing a thread-safety issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few thread-safety issues when profiling or tracing all threads via PyEval_SetProfileAllThreads or PyEval_SetTraceAllThreads:
c_profilefuncandc_tracefuncwasn't thread-safe on the free threading build. (cherry picked from commit a10152f)sys._setprofileallthreadsrace condition #137400