Skip to content

gh-140939: Fix memory leak in _PyBytes_FormatEx error path #140957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 6, 2025
Merged

gh-140939: Fix memory leak in _PyBytes_FormatEx error path #140957

merged 5 commits into from
Nov 6, 2025

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Nov 3, 2025 •
edited by bedevere-app bot
Loading

It is already accounted for in the other path:

cpython/Objects/bytesobject.c

Lines 1049 to 1054 in b373d34

if (dict && (argidx < arglen)) {
PyErr_SetString(PyExc_TypeError,
"not all arguments converted during bytes formatting");
Py_XDECREF(temp);
goto error;
}

@bedevere-app bedevere-app bot mentioned this pull request Nov 3, 2025
Closed
vstinner
vstinner reviewed Nov 5, 2025
View reviewed changes
vstinner
vstinner reviewed Nov 5, 2025
View reviewed changes
vstinner
vstinner reviewed Nov 5, 2025
View reviewed changes
vstinner
vstinner approved these changes Nov 5, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303 kumaraditya303 added type-bug An unexpected behavior, bug, or error needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 6, 2025
@kumaraditya303 kumaraditya303 merged commit d6c89a2 into python:main Nov 6, 2025
56 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Nov 6, 2025

Thanks @StanFromIreland for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Nov 6, 2025

Sorry, @StanFromIreland and @kumaraditya303, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d6c89a2df2c8b7603125883494e9058a88348f66 3.14

@miss-islington-app
Copy link

miss-islington-app bot commented Nov 6, 2025

Sorry, @StanFromIreland and @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d6c89a2df2c8b7603125883494e9058a88348f66 3.13

@StanFromIreland StanFromIreland deleted the bytes-leak branch November 6, 2025 07:22
@StanFromIreland
Copy link
Member Author

StanFromIreland commented Nov 6, 2025

I can backport.

@StanFromIreland StanFromIreland self-assigned this Nov 6, 2025
@bedevere-app
Copy link

bedevere-app bot commented Nov 6, 2025

GH-141154 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 6, 2025
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Nov 6, 2025
@StanFromIreland
[3.14] pythongh-140939: Fix memory leak in _PyBytes_FormatEx error …
72c7e46 
…path (pythonGH-140957)

(cherry picked from commit d6c89a2)

Co-authored-by: Stan Ulbrych <[email protected]>
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Nov 6, 2025
@StanFromIreland
[3.13] pythongh-140939: Fix memory leak in _PyBytes_FormatEx error …
ca6837d 
…path (pythonGH-140957)

(cherry picked from commit d6c89a2)

Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 6, 2025

GH-141155 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 6, 2025
vstinner pushed a commit that referenced this pull request Nov 6, 2025
@StanFromIreland
[3.13] gh-140939: Fix memory leak in _PyBytes_FormatEx error path (G…
f1a9372 
…H-140957) (#141155)

(cherry picked from commit d6c89a2)
vstinner pushed a commit that referenced this pull request Nov 6, 2025
@StanFromIreland
[3.14] gh-140939: Fix memory leak in _PyBytes_FormatEx error path (G…
ebf5459 
…H-140957) (#141154)

(cherry picked from commit d6c89a2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

+1 more reviewer

@RenaudBernier RenaudBernier RenaudBernier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StanFromIreland StanFromIreland

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland @vstinner @kumaraditya303 @RenaudBernier