gh-140980: document SET_FUNCTION_ATTRIBUTE flag for annotate function
#141306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
awaiting review
docs
picnixz
changed the title
SET_FUNCTION_ATTRIBUTE in dis
StanFromIreland
changed the title
SET_FUNCTION_ATTRIBUTE in disSET_FUNCTION_ATTRIBUTE in dis
picnixz
reviewed
Nov 9, 2025
picnixz
reviewed
Nov 9, 2025
Comment on lines
1681
to
1682
| Added ``0x10`` to indicate the annotate function for the function object. | ||
|
|
Member
There was a problem hiding this comment.
Can you put two blank lines between the end the sentence and the next .. opcode::? (see other paragraphs to check how they are separated)
picnixz
reviewed
Nov 9, 2025
Lakshya-Upadhyaya
force-pushed
the
document-set-function-attribute-16
branch
from
ae00464 to
38151bf
Compare
picnixz
approved these changes
Nov 9, 2025
picnixz
changed the title
SET_FUNCTION_ATTRIBUTE in disSET_FUNCTION_ATTRIBUTE flag for annotate function
|
Thanks @Lakshya-Upadhyaya for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Member
|
Thank you! |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 9, 2025
…` function (pythonGH-141306) (cherry picked from commit 6f20ea1) Co-authored-by: Lakshya Upadhyaya <[email protected]>
|
GH-141316 is a backport of this pull request to the 3.14 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-140980
This adds documentation for the
0x10bit flag (annotate) that was added toSET_FUNCTION_ATTRIBUTEin #124566. The bit sets the annotate function forthe function object.
📚 Documentation preview 📚: https://cpython-previews--141306.org.readthedocs.build/