bpo-39199: Use 'eval' mode for the examples with expression nodes #18828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
added
skip news
and removed
awaiting core review
docs
Co-Authored-By: Serhiy Storchaka <[email protected]>
Member
Author
Commit a8b092b moves all examples to use single quotes when possible |
Doc/library/ast.rst
Outdated
| op=USub(), | ||
| operand=Name(id='a', ctx=Load())))], | ||
| type_ignores=[]) | ||
| >>> print(ast.dump(ast.parse('-a', mode='eval'), indent=4)) |
Member
There was a problem hiding this comment.
This example should use the "exec" mode.
Member
Author
There was a problem hiding this comment.
Could you elaborate on the reason why? The difference between the two trees does not add anything that stands out to me:
>>> print(ast.dump(ast.parse('-a', mode='eval'), indent=4))
Expression(
body=UnaryOp(
op=USub(),
operand=Name(id='a', ctx=Load())))
>>> print(ast.dump(ast.parse('-a', mode='exec'), indent=4))
Module(
body=[
Expr(
value=UnaryOp(
op=USub(),
operand=Name(id='a', ctx=Load())))],
type_ignores=[])
Member
There was a problem hiding this comment.
It is an example for the Expr node.
Member
Author
There was a problem hiding this comment.
🤦♂️ Whops! Thanks, I clearly need more coffee.
Member
Author
|
Thank you very much @serhiy-storchaka for the awesome review! :) |
Member
|
Thank you for the great improvement of the documentation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39199