Skip to content

bpo-1635741: Port _random to multiphase initialization #23359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2020
Merged

bpo-1635741: Port _random to multiphase initialization #23359

merged 1 commit into from
Nov 19, 2020

Conversation

@tiran
Copy link
Member

@tiran tiran commented Nov 18, 2020 •
edited by miss-islington
Loading

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue1635741

Automerge-Triggered-By: GH:tiran

@tiran tiran requested a review from rhettinger as a code owner November 18, 2020 08:18
@tiran tiran mentioned this pull request Nov 18, 2020
Closed
@tiran tiran requested review from corona10 and vstinner November 18, 2020 23:37
vstinner
vstinner approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, perfect!

It's impressive that I wrote almost exactly the same PR!? :-D (PR #23381).

@miss-islington miss-islington merged commit cc0cd43 into python:master Nov 19, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@tiran @adorilson
bpo-1635741: Port _random to multiphase initialization (pythonGH-23359)
4f3a280 
Signed-off-by: Christian Heimes <[email protected]>
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

@corona10 corona10 Awaiting requested review from corona10

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tiran @vstinner @the-knights-who-say-ni @bedevere-bot @miss-islington