[3.9] [doc] Mention __slots__ behavior in weakref.rst (GH-21061) #28773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It took me longer than I expected to figure out why a random class I dealt with didn't support weak references. I believe this addition will make the __slots__/weakref interaction more discoverable to people having troubles with this. (Before this patch __slots__ was not mentioned in weakref documentation even once). Co-authored-by: Łukasz Langa <[email protected]> (cherry picked from commit b24b47e) Co-authored-by: Jakub Stasiak <[email protected]>
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me longer than I expected to figure out why a random class
I dealt with didn't support weak references. I believe this addition
will make the slots/weakref interaction more discoverable to people
having troubles with this. (Before this patch slots was not
mentioned in weakref documentation even once).
Co-authored-by: Łukasz Langa [email protected]
(cherry picked from commit b24b47e)
Co-authored-by: Jakub Stasiak [email protected]